Skip to content

ENH: add missing methods to .dt for Period, resolves #8848 #12463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: add missing methods to .dt for Period, resolves #8848 #12463

wants to merge 1 commit into from

Conversation

rosnfeld
Copy link
Contributor

Not 100% complete, but putting this in as a place to house comments:

  • I am not sure where to put the whatsnew entry - 0.18.0 or 0.18.1?
  • Also not sure if you'd like tests on the actual usage in the .dt accessor, there are actually no tests anywhere in pandas (as far as I can tell) on period_series.dt.* (as opposed to PeriodIndex). I just added a couple PeriodIndex tests.

@jreback jreback added API Design Period Period data type labels Feb 26, 2016
@jreback
Copy link
Contributor

jreback commented Feb 26, 2016

the tests on .dt. usage are all in tests/series/test_datetime_values.py, so pls add there

@jreback
Copy link
Contributor

jreback commented Feb 26, 2016

0.18.0 is good.

@jreback jreback added this to the 0.18.0 milestone Feb 26, 2016
@rosnfeld
Copy link
Contributor Author

Ok, I think a proper first pass on this is done now, let me know if there's more you would like.

@jreback jreback closed this in 91967c8 Feb 27, 2016
@jreback
Copy link
Contributor

jreback commented Feb 27, 2016

thank you sir!

@rosnfeld rosnfeld deleted the issue_8848 branch February 27, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design Period Period data type
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

ENH: add missing methods to .dt for Period
3 participants
@rosnfeld @jreback @andrew-rosenfeld-ts